Conversation
Signed-off-by: Edward Payzant <payzantedwardiv@gmail.com>
Signed-off-by: Edward Payzant <adam@synadia.com>
Signed-off-by: Edward Payzant <adam@synadia.com>
31b6870 to
d313fe5
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
==========================================
+ Coverage 70.33% 70.37% +0.03%
==========================================
Files 48 48
Lines 17447 17503 +56
Branches 3573 3583 +10
==========================================
+ Hits 12271 12317 +46
+ Misses 1737 1735 -2
- Partials 3439 3451 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@AdamPayzant Also, the ADR mentions using the reply subject for operations, etc.. so I guess that changed to instead use headers? More importantly, there is a mention that starting the batch should wait for the puback before proceeding with the rest. I don't see that being done in this PR. |
Signed-off-by: Edward Payzant <adam@synadia.com>
|
@kozlovic unless I misunderstood, what you're looking at in the ADR is for the 2.14 Fast-ingest feature. I plan to start working on that soon, though I believe that should be added to the orbit.c library that's being worked on rather than the client directly (though changes in the client may be necessary). |
Signed-off-by: Edward Payzant <adam@synadia.com>
Signed-off-by: Edward Payzant <adam@synadia.com>
kozlovic
left a comment
There was a problem hiding this comment.
Small updates to the doc needed and I think we are good to go.
Signed-off-by: Edward Payzant <adam@synadia.com>
…atomic_batch_publish
Adding 2.12 implementation for JetStream Batch Publishing (ADR-50)