Skip to content

[ADDED] Atomic batch publish support#977

Merged
kozlovic merged 7 commits intomainfrom
atomic_batch_publish
Mar 27, 2026
Merged

[ADDED] Atomic batch publish support#977
kozlovic merged 7 commits intomainfrom
atomic_batch_publish

Conversation

@AdamPayzant
Copy link
Copy Markdown
Collaborator

Adding 2.12 implementation for JetStream Batch Publishing (ADR-50)

AdamPayzant and others added 3 commits March 4, 2026 13:50
Signed-off-by: Edward Payzant <payzantedwardiv@gmail.com>
Signed-off-by: Edward Payzant <adam@synadia.com>
Signed-off-by: Edward Payzant <adam@synadia.com>
@AdamPayzant AdamPayzant force-pushed the atomic_batch_publish branch from 31b6870 to d313fe5 Compare March 4, 2026 18:51
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

❌ Patch coverage is 66.12903% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.37%. Comparing base (6f0f5c4) to head (0356ccf).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/js.c 66.10% 8 Missing and 12 partials ⚠️
src/jsm.c 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #977      +/-   ##
==========================================
+ Coverage   70.33%   70.37%   +0.03%     
==========================================
  Files          48       48              
  Lines       17447    17503      +56     
  Branches     3573     3583      +10     
==========================================
+ Hits        12271    12317      +46     
+ Misses       1737     1735       -2     
- Partials     3439     3451      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdamPayzant AdamPayzant requested a review from kozlovic March 26, 2026 14:04
@kozlovic
Copy link
Copy Markdown
Member

@AdamPayzant Also, the ADR mentions using the reply subject for operations, etc.. so I guess that changed to instead use headers? More importantly, there is a mention that starting the batch should wait for the puback before proceeding with the rest. I don't see that being done in this PR.

Signed-off-by: Edward Payzant <adam@synadia.com>
@AdamPayzant
Copy link
Copy Markdown
Collaborator Author

@kozlovic unless I misunderstood, what you're looking at in the ADR is for the 2.14 Fast-ingest feature. I plan to start working on that soon, though I believe that should be added to the orbit.c library that's being worked on rather than the client directly (though changes in the client may be necessary).

Signed-off-by: Edward Payzant <adam@synadia.com>
Signed-off-by: Edward Payzant <adam@synadia.com>
Copy link
Copy Markdown
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small updates to the doc needed and I think we are good to go.

Signed-off-by: Edward Payzant <adam@synadia.com>
Copy link
Copy Markdown
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit dffb248 into main Mar 27, 2026
28 checks passed
@kozlovic kozlovic deleted the atomic_batch_publish branch March 27, 2026 15:43
github-actions bot pushed a commit that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants